Skip to content

Fix own_substs ICE #103116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix own_substs ICE #103116

merged 1 commit into from
Oct 17, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Oct 16, 2022

Fixes #103053

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2022

Some changes occurred in need_type_info.rs

cc @lcnr

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
@lcnr
Copy link
Contributor

lcnr commented Oct 17, 2022

👍

r? @lcnr
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 17, 2022

📌 Commit 0b6fa0d has been approved by lcnr

It is now in the queue for this repository.

@rust-highfive rust-highfive assigned lcnr and unassigned estebank Oct 17, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022
@bors
Copy link
Collaborator

bors commented Oct 17, 2022

⌛ Testing commit 0b6fa0d with merge c19a893...

@bors
Copy link
Collaborator

bors commented Oct 17, 2022

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing c19a893 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 17, 2022
@bors bors merged commit c19a893 into rust-lang:master Oct 17, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 17, 2022
@TaKO8Ki TaKO8Ki deleted the fix-103053 branch October 17, 2022 13:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c19a893): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.0% [2.4%, 4.1%] 12
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.3% [-5.3%, -5.3%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

ICE in type checking when use type alias to construct struct
7 participants
@TaKO8Ki @rustbot @rust-highfive @lcnr @bors @rust-timer @estebank